Paths

Table of Contentst

Differential D6330

[backport#16129] Make reasoning about dependencies easier by not including unused dependencies
ClosedPublic
Actions

Authored by majcosta on Jun 2 2020, 19:42.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa66c80017899: [backport#16129] Make reasoning about dependencies easier by not including…

Summary

https://github.com/bitcoin/bitcoin/pull/16129/commits/eca97676737174ac6ff775c60e3798c69fb67f4a

Backport of Core PR16129

Test Plan

ninja
ninja check-all
cd ..
./test/lint/lint-circular-dependencies.sh

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 2 2020, 19:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2020, 19:42

majcosta requested review of this revision.Jun 2 2020, 19:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11145: Diff 20806.Jun 2 2020, 19:53

You're missing a change in txindex_tests.cpp
Please run the circular dependency linter as part of your test plan to check there is no circular dependency that remains from the lines removed.

src/test/coins_tests.cpp
20 ↗	(On Diff #20806)	?
src/test/torcontrol_tests.cpp
5 ↗	(On Diff #20806)	That's unexpected :)

This revision now requires changes to proceed.Jun 2 2020, 20:44

majcosta edited the test plan for this revision. (Show Details)Jun 2 2020, 20:57

majcosta edited the test plan for this revision. (Show Details)Jun 2 2020, 21:01

majcosta added inline comments.Jun 2 2020, 21:03

src/test/coins_tests.cpp
20 ↗	(On Diff #20806)	that was removed in D364, probably cleanup at the time.

Fabien accepted this revision.Jun 2 2020, 21:09

This revision is now accepted and ready to land.Jun 2 2020, 21:09

majcosta requested review of this revision.Jun 2 2020, 21:10

Fabien accepted this revision.Jun 2 2020, 21:11

This revision is now accepted and ready to land.Jun 2 2020, 21:11

Closed by commit rABCa66c80017899: [backport#16129] Make reasoning about dependencies easier by not including… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by majcosta). · Explain WhyJun 2 2020, 21:12

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCa66c80017899: [backport#16129] Make reasoning about dependencies easier by not including….

jasonbcox added a subscriber: jasonbcox.Jun 2 2020, 21:16

jasonbcox added inline comments.

src/core_read.cpp
5 ↗	(On Diff #20806)	This doesn't look right.

Revision Contents
Changeset List

Path

Size

src/

addrman.cpp

1 line

arith_uint256.cpp

1 line

bench/

1 line

2 lines

1 line

2 lines

3 lines

1 line

1 line

1 line

1 line

3 lines

consensus/

merkle.cpp

1 line

core_read.cpp

3 lines

core_write.cpp

1 line

crypto/

1 line

1 line

1 line

1 line

1 line

interfaces/

1 line

9 lines

1 line

1 line

2 lines

2 lines

3 lines

policy/

policy.cpp

3 lines

primitives/

block.cpp

1 line

psbt.cpp

3 lines

qt/

addressbookpage.cpp

1 line

addresstablemodel.cpp

1 line

2 lines

3 lines

2 lines

6 lines

coincontroldialog.cpp

2 lines

peertablemodel.cpp

1 line

platformstyle.cpp

2 lines

receivecoinsdialog.cpp

2 lines

test/

2 lines

3 lines

4 lines

1 line

2 lines

transactionrecord.cpp

3 lines

transactiontablemodel.cpp

4 lines

utilitydialog.cpp

5 lines

walletmodeltransaction.cpp

1 line

rpc/

1 line

9 lines

2 lines

1 line

6 lines

rawtransaction_util.cpp

1 line

server.cpp

2 lines

script/

script.cpp

1 line

sigcache.cpp

1 line

standard.cpp

2 lines

test/

coins_tests.cpp

5 lines

denialofservice_tests.cpp

1 line

multisig_tests.cpp

1 line

rpc_tests.cpp

2 lines

script_p2sh_tests.cpp

1 line

1 line

1 line

1 line

2 lines

2 lines

2 lines

util/

system.cpp

2 lines

validationinterface.cpp

2 lines

wallet/

4 lines

2 lines

4 lines

1 line

7 lines

test/

init_tests.cpp

3 lines

wallet_test_fixture.cpp

2 lines

wallet.cpp

5 lines

wallettool.cpp

1 line

zmq/

zmqabstractnotifier.cpp

2 lines

zmqnotificationinterface.cpp

1 line

test/

lint/

lint-circular-dependencies.sh

6 lines

Diff 20808

View Options

src/addrman.cpp

View Options

src/arith_uint256.cpp

View Options

src/bench/base58.cpp

View Options

src/bench/bench_bitcoin.cpp

View Options

src/bench/checkqueue.cpp

View Options

src/bench/crypto_hash.cpp

View Options

src/bench/duplicate_inputs.cpp

View Options

src/bench/examples.cpp

View Options

src/bench/rpc_mempool.cpp

View Options

src/bench/wallet_balance.cpp

View Options

src/bitcoin-wallet.cpp

View Options

src/bitcoind.cpp

View Options

src/consensus/merkle.cpp

View Options

src/core_read.cpp

View Options

src/core_write.cpp

View Options

src/crypto/aes.cpp

View Options

src/crypto/sha256_avx2.cpp

View Options

src/crypto/sha256_sse41.cpp

View Options

src/httprpc.cpp

View Options

src/init.cpp

View Options

src/interfaces/node.cpp

View Options

src/interfaces/wallet.cpp

View Options

src/key.cpp

View Options

src/merkleblock.cpp

View Options

src/miner.cpp

View Options

src/net_processing.cpp

View Options

src/netbase.cpp

View Options

src/policy/policy.cpp

View Options

src/primitives/block.cpp

View Options

src/psbt.cpp

View Options

src/qt/addressbookpage.cpp

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/bantablemodel.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoinunits.cpp

View Options

src/qt/clientmodel.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/platformstyle.cpp

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/test/addressbooktests.cpp

View Options

src/qt/test/apptests.cpp

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactiontablemodel.cpp

View Options

src/qt/utilitydialog.cpp

View Options

src/qt/walletmodeltransaction.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/protocol.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/server.cpp

View Options

src/script/script.cpp

View Options

src/script/sigcache.cpp

View Options

src/script/standard.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/torcontrol_tests.cpp

View Options

src/test/txindex_tests.cpp

View Options

src/timedata.cpp

View Options

src/txdb.cpp

View Options

src/txmempool.cpp

View Options

src/ui_interface.cpp

View Options

src/util/system.cpp

View Options

src/validationinterface.cpp

View Options

src/wallet/db.cpp

View Options

src/wallet/fees.cpp

View Options

src/wallet/init.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/init_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.cpp

View Options

src/wallet/wallet.cpp

View Options

src/wallet/wallettool.cpp

View Options

src/zmq/zmqabstractnotifier.cpp

View Options

src/zmq/zmqnotificationinterface.cpp

View Options

test/lint/lint-circular-dependencies.sh

[backport#16129] Make reasoning about dependencies easier by not including unused dependenciesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20808

src/addrman.cpp

src/arith_uint256.cpp

src/bench/base58.cpp

src/bench/bench_bitcoin.cpp

src/bench/checkqueue.cpp

src/bench/crypto_hash.cpp

src/bench/duplicate_inputs.cpp

src/bench/examples.cpp

src/bench/rpc_mempool.cpp

src/bench/wallet_balance.cpp

src/bitcoin-wallet.cpp

src/bitcoind.cpp

src/consensus/merkle.cpp

src/core_read.cpp

src/core_write.cpp

src/crypto/aes.cpp

src/crypto/sha256_avx2.cpp

src/crypto/sha256_sse41.cpp

src/httprpc.cpp

src/init.cpp

src/interfaces/node.cpp

src/interfaces/wallet.cpp

src/key.cpp

src/merkleblock.cpp

src/miner.cpp

src/net_processing.cpp

src/netbase.cpp

src/policy/policy.cpp

src/primitives/block.cpp

src/psbt.cpp

src/qt/addressbookpage.cpp

src/qt/addresstablemodel.cpp

src/qt/bantablemodel.cpp

src/qt/bitcoin.cpp

src/qt/bitcoinunits.cpp

src/qt/clientmodel.cpp

src/qt/coincontroldialog.cpp

src/qt/peertablemodel.cpp

src/qt/platformstyle.cpp

src/qt/receivecoinsdialog.cpp

src/qt/test/addressbooktests.cpp

src/qt/test/apptests.cpp

src/qt/test/rpcnestedtests.cpp

src/qt/test/wallettests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.cpp

src/qt/utilitydialog.cpp

src/qt/walletmodeltransaction.cpp

src/rpc/blockchain.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/protocol.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/server.cpp

src/script/script.cpp

src/script/sigcache.cpp

src/script/standard.cpp

src/test/coins_tests.cpp

src/test/denialofservice_tests.cpp

src/test/multisig_tests.cpp

src/test/rpc_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/torcontrol_tests.cpp

src/test/txindex_tests.cpp

src/timedata.cpp

src/txdb.cpp

src/txmempool.cpp

src/ui_interface.cpp

src/util/system.cpp

src/validationinterface.cpp

src/wallet/db.cpp

src/wallet/fees.cpp

[backport#16129] Make reasoning about dependencies easier by not including unused dependencies
ClosedPublic
Actions

Revision Contents
Changeset List