HomePhabricator

[Tests] Cleanup extra instances of create_transaction

Description

[Tests] Cleanup extra instances of create_transaction

Summary:
Partial backport of Core PR13669
https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540

Changes to feature_csv_activation.py omitted because they caused the
test to fail the assert in create_transaction() due to divergences in our codebases.
https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540#diff-72d4bdc0bac8c2153666b0a94544af94L50

Depends on D4820

Test Plan:

test/functional/test_runner.py abc-mempool-accept-txn abc-mempool-coherence-on-activations abc-minimaldata abc-replay-protection abc-schnorr abc-schnorrmultisig feature_block feature_cltv feature_dersig p2p_invalid_block p2p_invalid_tx p2p_unrequested_blocks

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4821

Details

Provenance
Conor Scott <conor.r.scott.88@gmail.com>Authored on Jul 30 2018, 08:16
nakihitoCommitted on Jan 6 2020, 17:41
nakihitoPushed on Jan 6 2020, 17:41
Reviewer
Restricted Owners Package
Differential Revision
D4821: [Tests] Cleanup extra instances of create_transaction
Parents
rABC30f58f2909cf: [Tests] Rename create_tx and move to blocktools.py
Branches
Unknown
Tags
Unknown