Page MenuHomePhabricator

[Tests] Cleanup extra instances of create_transaction
ClosedPublic

Authored by nakihito on Jan 2 2020, 21:48.

Details

Summary

Partial backport of Core PR13669
https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540

Changes to feature_csv_activation.py omitted because they caused the
test to fail the assert in create_transaction() due to divergences in our codebases.
https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540#diff-72d4bdc0bac8c2153666b0a94544af94L50

Depends on D4820

Test Plan
test/functional/test_runner.py abc-mempool-accept-txn abc-mempool-coherence-on-activations abc-minimaldata abc-replay-protection abc-schnorr abc-schnorrmultisig feature_block feature_cltv feature_dersig p2p_invalid_block p2p_invalid_tx p2p_unrequested_blocks

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 2 2020, 21:48
nakihito requested review of this revision.Jan 3 2020, 20:19
nakihito edited the summary of this revision. (Show Details)
nakihito added inline comments.
test/functional/feature_cltv.py
93 ↗(On Diff #15118)

This goes by a different name in our codebase, but is equivalent to Core's create_transaction() here: https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540#diff-50b4837bfc0343f848b10959ad7c5220L61

This revision is now accepted and ready to land.Jan 4 2020, 06:35