Paths

Table of Contentst

validation: pass ChainstateRole for validationinterface calls
aefa604d1845
Actions

Description

validation: pass ChainstateRole for validationinterface calls

Summary:
This allows consumers to decide how to handle events from background or assumedvalid chainstates.
For now there is no change in behavior.

This is a partial backport of core#27596
https://github.com/bitcoin/bitcoin/pull/27596/commits/c6af23c5179cc383f8e6c275373af8d11e6a989f
https://github.com/bitcoin/bitcoin/pull/27596/commits/4d8f4dcb450d31e4847804e62bf91545b949fa14

Depends on D17889

Test Plan:
ninja all check-all
Tested on my dev branch (full mainnet IBD + function test)

Reviewers: #bitcoin_abc, roqqit

Reviewed By: #bitcoin_abc, roqqit

Subscribers: Fabien, roqqit

Differential Revision: https://reviews.bitcoinabc.org/D17890

Details

Provenance

James O'Beirne <james.obeirne@pm.me>	Authored on Nov 10 2022, 17:03
PiRK	Committed on Fri, Apr 4, 12:14
PiRK	Pushed on Fri, Apr 4, 12:14

Reviewer

Restricted Project

Differential Revision

D17890: validation: pass ChainstateRole for validationinterface calls

Parents

rABC1fe0d049d7b0: validation: only call UpdatedBlockTip for active chainstate

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCaefa604d1845: validation: pass ChainstateRole for validationinterface calls (authored by James O'Beirne <james.obeirne@pm.me>).Fri, Apr 4, 12:14

PiRK added an edge: D17890: validation: pass ChainstateRole for validationinterface calls.

Changes (21)

Path

Size

chronik/

chronik-cpp/

chronik_validationinterface.cpp

src/

index/

interfaces/

kernel/

node/

test/

coinstatsindex_tests.cpp

util/

validation.cpp

validation.h

validation_block_tests.cpp

validation.cpp

validation.h

validationinterface.cpp

validationinterface.h

wallet/

wallet.cpp

wallet.h

zmq/

zmqnotificationinterface.cpp

zmqnotificationinterface.h

rABCaefa604d1845

View Options

chronik/chronik-cpp/chronik_validationinterface.cpp

View Options

src/CMakeLists.txt

View Options

src/index/base.cpp

View Options

src/index/base.h

View Options

src/interfaces/chain.h

View Options

src/kernel/chain.cpp

View Options

src/kernel/chain.h

View Options

src/net_processing.cpp

View Options

src/node/interfaces.cpp

View Options

src/test/coinstatsindex_tests.cpp

View Options

src/test/util/validation.cpp

View Options

src/test/util/validation.h

View Options

src/test/validation_block_tests.cpp

View Options

src/validation.cpp

View Options

src/validation.h

View Options

src/validationinterface.cpp

View Options

src/validationinterface.h

View Options

src/wallet/wallet.cpp

View Options

src/wallet/wallet.h

View Options

src/zmq/zmqnotificationinterface.cpp

View Options

src/zmq/zmqnotificationinterface.h

validation: pass ChainstateRole for validationinterface callsaefa604d1845Actions

Description

Details

Event Timeline

Changes (21)

rABCaefa604d1845

chronik/chronik-cpp/chronik_validationinterface.cpp

src/CMakeLists.txt

src/index/base.cpp

src/index/base.h

src/interfaces/chain.h

src/kernel/chain.cpp

src/kernel/chain.h

src/net_processing.cpp

src/node/interfaces.cpp

src/test/coinstatsindex_tests.cpp

src/test/util/validation.cpp

src/test/util/validation.h

src/test/validation_block_tests.cpp

src/validation.cpp

src/validation.h

src/validationinterface.cpp

src/validationinterface.h

src/wallet/wallet.cpp

src/wallet/wallet.h

src/zmq/zmqnotificationinterface.cpp

src/zmq/zmqnotificationinterface.h

validation: pass ChainstateRole for validationinterface calls
aefa604d1845
Actions