Paths

Table of Contentst

Differential D17890

validation: pass ChainstateRole for validationinterface calls
ClosedPublic
Actions

Authored by PiRK on Thu, Apr 3, 13:38.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCaefa604d1845: validation: pass ChainstateRole for validationinterface calls

Summary

This allows consumers to decide how to handle events from background or assumedvalid chainstates.
For now there is no change in behavior.

This is a partial backport of core#27596
https://github.com/bitcoin/bitcoin/pull/27596/commits/c6af23c5179cc383f8e6c275373af8d11e6a989f
https://github.com/bitcoin/bitcoin/pull/27596/commits/4d8f4dcb450d31e4847804e62bf91545b949fa14

Depends on D17889

Test Plan

ninja all check-all
Tested on my dev branch (full mainnet IBD + function test)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, Apr 3, 13:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 3, 13:38

PiRK requested review of this revision.Thu, Apr 3, 13:38

teamcity edited the summary of this revision. (Show Details)Thu, Apr 3, 13:38

revert unrelated blank line changes

PiRK added a child revision: D17891: validationinterface: only send zmq notifications for active.Thu, Apr 3, 13:46

Harbormaster completed remote builds in B32885: Diff 53356.Thu, Apr 3, 14:00

Harbormaster completed remote builds in B32886: Diff 53357.Thu, Apr 3, 14:10

roqqit added a parent revision: D17889: validation: only call UpdatedBlockTip for active chainstate.Thu, Apr 3, 17:05

roqqit edited the summary of this revision. (Show Details)

roqqit requested changes to this revision.Thu, Apr 3, 17:29

roqqit added a subscriber: roqqit.

roqqit added inline comments.

chronik/chronik-cpp/chronik_validationinterface.cpp
54 ↗	(On Diff #53357)	does chronik assume a new block connected is always the tip? if so, this needs to be looked at
src/kernel/chain.h
9 ↗	(On Diff #53357)	What's the plan for the out-of-order backport from PR25494?
src/test/validationinterface_tests.cpp
7 ↗	(On Diff #53357)	I see it in the original PR but is it necessary?

This revision now requires changes to proceed.Thu, Apr 3, 17:29

Fabien added a subscriber: Fabien.Thu, Apr 3, 17:55

Fabien added inline comments.

chronik/chronik-cpp/chronik_validationinterface.cpp
54 ↗	(On Diff #53357)	For now chronik and assumeutxo are incompatible

PiRK added inline comments.Thu, Apr 3, 19:22

chronik/chronik-cpp/chronik_validationinterface.cpp
54 ↗	(On Diff #53357)	I do plan to only handle this signal for the background ibd, so that chronik gets the block in the correct order. It will be in the next commit https://github.com/PiRK/bitcoin-abc/pull/1/commits/39ca0b006b2fd9904901ec4507f5cb83ce3bf0ba But as Fabien says, official proper support for chronik+assumeutxo will come at a later stage.
src/kernel/chain.h
9 ↗	(On Diff #53357)	I tried backporting it but found that it brings in all kinds of dependencies to the `multiprocess` project (https://github.com/bitcoin/bitcoin/issues/28722). It's something desirable that we probably want to backport at some point, but that is going to take a lot of work just to get started (cmake, dependency to a new IPC library...), so I prefer to avoid it. The only connection to this PR is the creation of this new source file, but nothing in that file added by pr25494 is needed for assumeutxo.

remove unused include in validation_interface_tests, use a forward declaration in other modules where we currently rely on an implicit inclusion via validation.h

Harbormaster completed remote builds in B32890: Diff 53363.Thu, Apr 3, 20:15

roqqit accepted this revision.Thu, Apr 3, 21:49

This revision is now accepted and ready to land.Thu, Apr 3, 21:49

Closed by commit rABCaefa604d1845: validation: pass ChainstateRole for validationinterface calls (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyFri, Apr 4, 12:14

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCaefa604d1845: validation: pass ChainstateRole for validationinterface calls.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

chronik_validationinterface.cpp

4 lines

src/

2 lines

index/

6 lines

6 lines

interfaces/

7 lines

kernel/

30 lines

22 lines

net_processing.cpp

7 lines

node/

10 lines

test/

coinstatsindex_tests.cpp

4 lines

util/

3 lines

6 lines

validation_block_tests.cpp

5 lines

7 lines

14 lines

validationinterface.h

18 lines

validationinterface.cpp

15 lines

wallet/

6 lines

12 lines

zmq/

zmqnotificationinterface.h

3 lines

zmqnotificationinterface.cpp

3 lines

Diff 53368

chronik/chronik-cpp/chronik_validationinterface.cpp

Loading...

src/CMakeLists.txt

Loading...

src/index/base.h

Loading...

src/index/base.cpp

Loading...

src/interfaces/chain.h

Loading...

src/kernel/chain.h

Loading...

src/kernel/chain.cpp

Loading...

src/net_processing.cpp

Loading...

src/node/interfaces.cpp

Loading...

src/test/coinstatsindex_tests.cpp

Loading...

src/test/util/validation.h

Loading...

src/test/util/validation.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/validationinterface.h

Loading...

src/validationinterface.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...

src/zmq/zmqnotificationinterface.h

Loading...

src/zmq/zmqnotificationinterface.cpp

Loading...