HomePhabricator

test: Replace gArgs with local argsman in bench

Description

test: Replace gArgs with local argsman in bench

Summary:

  • tools: Add unused argsman to bench_bitcoin
  • scripted-diff: Replace gArgs with local argsman in bench

-BEGIN VERIFY SCRIPT-
sed -i -e 's/gArgs/argsman/g' src/bench/bench_bitcoin.cpp
-END VERIFY SCRIPT-

  • bench: Remove unused argsman.ClearArgs
  • util: Document why ArgsManager (con/de)structor is not inline

Backport of Core PR18662

Test Plan:

ninja bench-bitcoin

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8079

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Apr 15 2020, 22:53
deadalnixCommitted on Oct 23 2020, 14:27
deadalnixPushed on Oct 23 2020, 14:27
Reviewer
Restricted Project
Differential Revision
D8079: test: Replace gArgs with local argsman in bench
Parents
rABCaf0d6d4863e8: qt: Change default size of intro frame
Branches
Unknown
Tags
Unknown