HomePhabricator

Kill SegWit Step 11: Remove HasWitness
Concern Raisedbdb377d68ea8

Description

Kill SegWit Step 11: Remove HasWitness

Details

Auditors
awemany
Provenance
deadalnixAuthored on Apr 5 2017, 19:41
deadalnixPushed on May 14 2017, 22:04
Parents
rABCcf343ce7e51c: Kill SegWit Step 10: Remove GetWitnessHash
Branches
Unknown
Tags
Unknown

Event Timeline

awemany raised a concern with this commit.Jun 13 2017, 12:08
awemany added a subscriber: awemany.

Hi deadalnix,

currently skimming through all the commits on top of Core chronologically, to familiarize myself with everything. This fragment you changed caught my eyes:

else if (RecursiveDynamicUsage(*ptx) < 100000) {
           AddToCompactExtraTransactions(ptx);
       }

in net-processing.cpp. This seems to be the opposite of short-circuit evaluating fWitness to false, which you apparently did everywhere else. Don't have the high level view yet whether it still fits, however ...

This commit now has outstanding concerns.Jun 13 2017, 12:08