HomePhabricator

[backport#15709] wallet: Do not add "setting" key as unknown

Description

[backport#15709] wallet: Do not add "setting" key as unknown

Summary:

914923d125f5d17b39b4dc05f666d130e80a68b2 Add setting as known type (Peter Bushnell)

Pull request description:

When loading old wallets I get "Unknown wallet records" showing up in the log file. The key that is adding to the unknown record count is "setting", this is a known key removed in the 0.6 release of Bitcoin in the commit linked below. The "setting" key is not known to the wallet anymore, like "acentry" which is not added as an unknown record, but the "setting" key was used in previous versions of Bitcoin.

https://github.com/bitcoin/bitcoin/pull/15709/commits/914923d125f5d17b39b4dc05f666d130e80a68b2


Depends on D7021
Backport of Core PR15709

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7022

Details

Provenance
MeshCollider <dobsonsa68@gmail.com>Authored on Jul 30 2019, 08:31
majcostaCommitted on Jul 24 2020, 13:26
majcostaPushed on Jul 24 2020, 13:26
Reviewer
Restricted Project
Differential Revision
D7022: [backport#15709] wallet: Do not add "setting" key as unknown
Parents
rABC8bfda2e10fd7: [backport#16475 2/2] wallet: Rename CWalletKey to OldKey
Branches
Unknown
Tags
Unknown