Page MenuHomePhabricator

[backport#15709] wallet: Do not add "setting" key as unknown
ClosedPublic

Authored by majcosta on Thu, Jul 23, 06:00.

Details

Summary
914923d125f5d17b39b4dc05f666d130e80a68b2 Add setting as known type (Peter Bushnell)

Pull request description:

When loading old wallets I get "Unknown wallet records" showing up in the log file. The key that is adding to the unknown record count is "setting", this is a known key removed in the 0.6 release of Bitcoin in the commit linked below. The "setting" key is not known to the wallet anymore, like "acentry" which is not added as an unknown record, but the "setting" key was used in previous versions of Bitcoin.

https://github.com/bitcoin/bitcoin/pull/15709/commits/914923d125f5d17b39b4dc05f666d130e80a68b2


Depends on D7021
Backport of Core PR15709

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 06:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 06:00
majcosta requested review of this revision.Thu, Jul 23, 06:00
Fabien requested changes to this revision.Thu, Jul 23, 09:09
Fabien added a subscriber: Fabien.

See D7020

This revision now requires changes to proceed.Thu, Jul 23, 09:09
majcosta requested review of this revision.Thu, Jul 23, 21:02

since we've decided to go with the slightly tweaked D7020, putting this up for review again

Fabien accepted this revision.Fri, Jul 24, 12:46
This revision is now accepted and ready to land.Fri, Jul 24, 12:46
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.