Page MenuHomePhabricator

[backport#15588 3/3] Remove ReadVersion and WriteVersion
ClosedPublic

Authored by majcosta on Thu, Jul 23, 03:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd81f0d2aae5c: [backport#15588 3/3] Remove ReadVersion and WriteVersion
Summary

The "version" record that these functions read and write are not
used anywhere in the code except for one place. There is no reason
to expose these functions publicly. Furthermore, this avoids potential
confusion as developers may mistake these functions for actually
reading and writing the wallet version when they do not.

https://github.com/bitcoin/bitcoin/pull/15588/commits/35e60e790f2cd602d1bdd0be835d27f0ba37efa9


Depends on D7018

Concludes backport of Core PR15588

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 03:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 03:59
majcosta requested review of this revision.Thu, Jul 23, 03:59
Fabien accepted this revision.Thu, Jul 23, 08:51
This revision is now accepted and ready to land.Thu, Jul 23, 08:51
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.