Page MenuHomePhabricator
Differential D7019

[backport#15588 3/3] Remove ReadVersion and WriteVersion
ClosedPublic
Actions

Authored by majcosta on Jul 23 2020, 03:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd81f0d2aae5c: [backport#15588 3/3] Remove ReadVersion and WriteVersion
Summary

The "version" record that these functions read and write are not
used anywhere in the code except for one place. There is no reason
to expose these functions publicly. Furthermore, this avoids potential
confusion as developers may mistake these functions for actually
reading and writing the wallet version when they do not.

https://github.com/bitcoin/bitcoin/pull/15588/commits/35e60e790f2cd602d1bdd0be835d27f0ba37efa9

Depends on D7018

Concludes backport of Core PR15588

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 23 2020, 03:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2020, 03:59
majcosta requested review of this revision.Jul 23 2020, 03:59
Harbormaster completed remote builds in B12122: Diff 22446.Jul 23 2020, 04:18
majcosta added a child revision: D7020: [backport#16475 1/2] wallet: Enumerate walletdb keys.Jul 23 2020, 05:37
Fabien accepted this revision.Jul 23 2020, 08:51
This revision is now accepted and ready to land.Jul 23 2020, 08:51
Closed by commit rABCd81f0d2aae5c: [backport#15588 3/3] Remove ReadVersion and WriteVersion (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJul 23 2020, 15:43
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd81f0d2aae5c: [backport#15588 3/3] Remove ReadVersion and WriteVersion.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
9 lines
2 lines
5 lines
12 lines

Diff 22472

View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...