Page MenuHomePhabricator

[backport#15588 1/3] Remove nFileVersion from CWalletScanState
ClosedPublic

Authored by majcosta on Thu, Jul 23, 03:50.

Details

Summary

nFileVersion is not the actual file version and is not used except
in one place. So it is removed from CWalletScanState and changed so
that it is just read at the place it is needed. Furthermore, the
"version" record now only indicates the version of the highest
versioned client that has opened a wallet file so the variable
name is changed accordingly

https://github.com/bitcoin/bitcoin/pull/15588/commits/c88e87c3b2be3f97b712107e04285d06dfef3878


Partial backport of Core PR15588

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 03:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 03:50
Fabien accepted this revision.Thu, Jul 23, 08:48
This revision is now accepted and ready to land.Thu, Jul 23, 08:48
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.