Page MenuHomePhabricator

[backport#16502] wallet: Drop unused OldKey
ClosedPublic

Authored by majcosta on Thu, Jul 23, 06:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaab16958ccd8: [backport#16502] wallet: Drop unused OldKey
Summary
0b1f4b3c6685d0a6307926d43d166add538061b7 wallet: Drop unused OldKey (João Barbosa)

Pull request description:

Replaces #16494, `OldKey` (previously `CWalletKey`) was never serialized in the code history which means that unserialization support is not required, so remove the code entirely.

https://github.com/bitcoin/bitcoin/pull/16502/commits/0b1f4b3c6685d0a6307926d43d166add538061b7


Depends on D7022

Backport of Core PR16502

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 06:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 06:09
majcosta requested review of this revision.Thu, Jul 23, 06:09
Fabien requested changes to this revision.Thu, Jul 23, 09:11
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/walletdb.cpp
429 ↗(On Diff #22450)

Update the version

This revision now requires changes to proceed.Thu, Jul 23, 09:11
majcosta updated this revision to Diff 22473.Thu, Jul 23, 15:56

changed version suggestion to point to 0.20

Fabien accepted this revision.Thu, Jul 23, 20:48
This revision is now accepted and ready to land.Thu, Jul 23, 20:48
This revision was automatically updated to reflect the committed changes.
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.