Page MenuHomePhabricator
Differential D7023

[backport#16502] wallet: Drop unused OldKey
ClosedPublic
Actions

Authored by majcosta on Jul 23 2020, 06:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaab16958ccd8: [backport#16502] wallet: Drop unused OldKey
Summary
0b1f4b3c6685d0a6307926d43d166add538061b7 wallet: Drop unused OldKey (João Barbosa)

Pull request description:

Replaces #16494, `OldKey` (previously `CWalletKey`) was never serialized in the code history which means that unserialization support is not required, so remove the code entirely.

https://github.com/bitcoin/bitcoin/pull/16502/commits/0b1f4b3c6685d0a6307926d43d166add538061b7

Depends on D7022

Backport of Core PR16502

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 23 2020, 06:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2020, 06:09
majcosta requested review of this revision.Jul 23 2020, 06:09
Harbormaster completed remote builds in B12126: Diff 22450.Jul 23 2020, 06:24
Fabien requested changes to this revision.Jul 23 2020, 09:11
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/walletdb.cpp
429 ↗(On Diff #22450)

Update the version

This revision now requires changes to proceed.Jul 23 2020, 09:11
majcosta updated this revision to Diff 22473.Jul 23 2020, 15:56

changed version suggestion to point to 0.20

Harbormaster completed remote builds in B12136: Diff 22473.Jul 23 2020, 16:15
Fabien accepted this revision.Jul 23 2020, 20:48
This revision is now accepted and ready to land.Jul 23 2020, 20:48
Closed by commit rABCaab16958ccd8: [backport#16502] wallet: Drop unused OldKey (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyJul 24 2020, 13:27
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCaab16958ccd8: [backport#16502] wallet: Drop unused OldKey.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
25 lines
21 lines

Diff 22485

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...