Page MenuHomePhabricator

[backport#16475 1/2] wallet: Enumerate walletdb keys
ClosedPublic

Authored by majcosta on Thu, Jul 23, 05:37.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 05:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 05:37
Fabien requested changes to this revision.Thu, Jul 23, 09:05
Fabien added a subscriber: Fabien.

Your missing the pseudo enum declaration in walletdb.h

This revision now requires changes to proceed.Thu, Jul 23, 09:05
majcosta requested review of this revision.Thu, Jul 23, 15:51

Hm, I'd rather deal with the possibility of more or less straightforward merge conflicts in the future than repeating code there. If the fake enum is ever needed outside walletdb or in the header, we can just move it to the header.

deadalnix accepted this revision.Thu, Jul 23, 17:51
Fabien accepted this revision.Thu, Jul 23, 20:47

Fair enough

This revision is now accepted and ready to land.Thu, Jul 23, 20:47
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.