Page MenuHomePhabricator
Differential D7020

[backport#16475 1/2] wallet: Enumerate walletdb keys
ClosedPublic
Actions

Authored by majcosta on Jul 23 2020, 05:37.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe4c259cabb5c: [backport#16475 1/2] wallet: Enumerate walletdb keys
Summary

https://github.com/bitcoin/bitcoin/pull/16475/commits/fa6dc7fa5fdfd76c6dd5f7ae693a2fb4e37e271f

Depends on D7019

Partial backport of Core PR16475

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 23 2020, 05:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2020, 05:37
majcosta requested review of this revision.Jul 23 2020, 05:37
majcosta added a child revision: D7021: [backport#16475 2/2] wallet: Rename CWalletKey to OldKey.
Harbormaster completed remote builds in B12123: Diff 22447.Jul 23 2020, 05:54
Fabien requested changes to this revision.Jul 23 2020, 09:05
Fabien added a subscriber: Fabien.

Your missing the pseudo enum declaration in walletdb.h

This revision now requires changes to proceed.Jul 23 2020, 09:05
Fabien mentioned this in D7022: [backport#15709] wallet: Do not add "setting" key as unknown.Jul 23 2020, 09:09
majcosta requested review of this revision.Jul 23 2020, 15:51

Hm, I'd rather deal with the possibility of more or less straightforward merge conflicts in the future than repeating code there. If the fake enum is ever needed outside walletdb or in the header, we can just move it to the header.

deadalnix accepted this revision.Jul 23 2020, 17:51
Fabien accepted this revision.Jul 23 2020, 20:47

Fair enough

This revision is now accepted and ready to land.Jul 23 2020, 20:47
Closed by commit rABCe4c259cabb5c: [backport#16475 1/2] wallet: Enumerate walletdb keys (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJul 23 2020, 22:47
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe4c259cabb5c: [backport#16475 1/2] wallet: Enumerate walletdb keys.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien mentioned this in D8596: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}.Dec 3 2020, 16:14
Fabien mentioned this in rABCddb5baf776f9: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}.Dec 7 2020, 08:36
majcosta mentioned this in D8633: [refactor] use compile time string_view for DBKeys.Dec 9 2020, 13:02

Revision Contents
Changeset List

PathSize
src/
wallet/
171 lines

Diff 22477

View Options

src/wallet/walletdb.cpp

Loading...