Paths

Table of Contentst

Differential D8596

Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}
ClosedPublic
Actions

Authored by Fabien on Dec 3 2020, 16:14.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCddb5baf776f9: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}

Summary

Partial backport (9/11) of core PR18918:
https://github.com/bitcoin/bitcoin/pull/18918/commits/9ea2d258b46e8a9776100633585ed0feede5c2a4

Depends on D8595.

The DBKeys declaration are added to the walletdb.h file to make them
available for salvage.cpp, see D7020.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 3 2020, 16:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2020, 16:14

Fabien requested review of this revision.Dec 3 2020, 16:14

teamcity edited the summary of this revision. (Show Details)Dec 3 2020, 16:15

Fabien added a child revision: D8597: Move RecoverKeysOnlyFilter into RecoverDataBaseFile.Dec 3 2020, 16:15

Harbormaster completed remote builds in B14294: Diff 26174.Dec 3 2020, 17:01

majcosta accepted this revision.Dec 3 2020, 19:56

This revision is now accepted and ready to land.Dec 3 2020, 19:56

Closed by commit rABCddb5baf776f9: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h} (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyDec 7 2020, 08:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCddb5baf776f9: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}.

majcosta mentioned this in D8633: [refactor] use compile time string_view for DBKeys.Dec 9 2020, 13:02

Revision Contents
Changeset List

Path

Size

src/

wallet/

1 line

6 lines

139 lines

23 lines

170 lines

37 lines

22 lines

1 line

Diff 26222

View Options

src/wallet/CMakeLists.txt

View Options

src/wallet/db.h

View Options

src/wallet/db.cpp

View Options

src/wallet/salvage.h

View Options

src/wallet/salvage.cpp

View Options

src/wallet/walletdb.h

View Options

src/wallet/walletdb.cpp

View Options

Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26222

src/wallet/CMakeLists.txt

src/wallet/db.h

src/wallet/db.cpp

src/wallet/salvage.h

src/wallet/salvage.cpp

src/wallet/walletdb.h

src/wallet/walletdb.cpp

src/wallet/wallettool.cpp

Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}
ClosedPublic
Actions

Revision Contents
Changeset List