HomePhabricator

refactor: remove usage of locale dependent std::isspace

Description

refactor: remove usage of locale dependent std::isspace

Summary:
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...)
(uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)

Backport of core PR14585

Depends on D2698

Test Plan:

./test/lint/lint-locale-dependence.sh

Ensure there is no output

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2706

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Oct 26 2018, 16:54
FabienCommitted on Mar 20 2019, 14:15
FabienPushed on Mar 20 2019, 14:15
Reviewer
Restricted Project
Differential Revision
D2706: refactor: remove usage of locale dependent std::isspace
Parents
rABC6a7b8df807b2: [LINTER] build: Add linter for checking accidental locale dependence
Branches
Unknown
Tags
Unknown

Event Timeline

Fabien committed rABCc22ea26bba07: refactor: remove usage of locale dependent std::isspace (authored by practicalswift <practicalswift@users.noreply.github.com>).Mar 20 2019, 14:15