Page MenuHomePhabricator

refactor: remove usage of locale dependent std::isspace
ClosedPublic

Authored by Fabien on Mar 19 2019, 13:31.

Details

Summary

Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...)
(uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)

Backport of core PR14585

Depends on D2698

Test Plan
./test/lint/lint-locale-dependence.sh

Ensure there is no output

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 19 2019, 13:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2019, 13:31
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Mar 19 2019, 16:21
This revision is now accepted and ready to land.Mar 19 2019, 16:21
This revision was automatically updated to reflect the committed changes.