HomePhabricator

Refactor signature encoding checks

Authored by Mengerian on Feb 1 2019, 04:53.

Description

Refactor signature encoding checks

Summary:
Isolate ECDSA-specific parts in preparation for Schnorr.

Next steps would be:

  • Disallow 64 byte ECDSA signatures in CheckRawECDSASignatureEncoding when SCRIPT_ENABLE_SCHNORR flag is set (D2469)
  • Add Schnorr-specific functions for checking signature encodings

Test Plan: make check

Reviewers: markblundeberg, deadalnix, #bitcoin_abc

Reviewed By: markblundeberg, deadalnix, #bitcoin_abc

Subscribers: teamcity, schancel

Maniphest Tasks: T527

Differential Revision: https://reviews.bitcoinabc.org/D2477

Details

Committed
MengerianFeb 1 2019, 23:32
Pushed
MengerianFeb 1 2019, 23:34
Reviewer
Restricted Project
Differential Revision
D2477: Refactor signature encoding checks
Parents
rABCe6ac0d1db5d5: sigencoding_tests : use pseudorandom generator for flag patterns
Branches
Unknown
Tags
Unknown