[schnorr functional test] remove ComparisonTestFramework dependency
c5c9afad5db9
Actions

Description

[schnorr functional test] remove ComparisonTestFramework dependency

Summary:
This switches the Schnorr test to not rely on comptool (which is
deprecated), and takes advantage of the newly backported P2PDataStore
features. bootstrap_p2p and reconnect_p2p are borrowed from
p2p_invalid_tx.py (introduced D3527).

This nicely removes the need to rely on -whitelist for rejected
blocks, instead we can send them and get "banned" (disconnected), and
then reconnect.

I've also added some logging to the test, while I'm at it.

Test Plan: ./test/functional/test_runner.py abc-schnorr.py

Reviewers: Mengerian, Fabien, jasonbcox, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3601

Details

Provenance

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>	Authored on Jul 9 2019, 03:11
markblundeberg	Pushed on Jul 10 2019, 00:36

Reviewer

Restricted Project

Differential Revision

D3601: [schnorr functional test] remove ComparisonTestFramework dependency

Parents

rABC71ee453fecf0: Merge #10684: Remove no longer used mempool.exists(outpoint)

Branches

Unknown

Tags

Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCc5c9afad5db9: [schnorr functional test] remove ComparisonTestFramework dependency (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jul 10 2019, 00:36

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added an edge: D3601: [schnorr functional test] remove ComparisonTestFramework dependency.