Page MenuHomePhabricator

Merge #13003: qa: Add test for orphan handling
ClosedPublic

Authored by markblundeberg on Jul 2 2019, 19:50.

Details

Summary

PR13003 backport https://github.com/bitcoin/bitcoin/pull/13003/files
fa02c5b qa: Clarify documentation for send_txs_and_test (MarcoFalke)
fadfbd3 qa: Add test for orphan handling (MarcoFalke)

Backport note: needed pad_tx for these

Depends on D3514

Test Plan

test_runner.py p2p_invalid_tx.py
test_runner.py feature_block.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 2 2019, 19:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 19:50

Note that this removes -whitelist , and adds this expect_disconnect feature. This is will let us do nicer tests of transaction banning/non-banning for mandatory flags.

deadalnix accepted this revision.Jul 3 2019, 13:11
This revision is now accepted and ready to land.Jul 3 2019, 13:11
markblundeberg added inline comments.Jul 3 2019, 15:03
test/functional/p2p_invalid_tx.py
61

This was supposed to be removing "# Verify valid transaction ..." that would have been added in D3511, but I mistakenly backported out of order. Will be resynced after D3511 lands.