Page MenuHomePhabricator

Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework
ClosedPublic

Authored by markblundeberg on Jul 2 2019, 01:15.

Details

Summary

PR11772 backport https://github.com/bitcoin/bitcoin/pull/11772/files
e97b113b04 [tests] Change invalidblockrequest to use BitcoinTestFramework (John Newbery)
2b7064eda7 [tests] Fix flake8 warnings in invalidblockrequest (John Newbery)
54b8c580b7 [test] Fix nits leftover from 11771 (Conor Scott)

Pull request description:

Builds on #11771. Please review that PR first

Next step in #10603.

- first commit tidies up invalidblockrequest.py
- second commit removes usage of ComparisonTestFramework
Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 2 2019, 01:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 01:15
markblundeberg planned changes to this revision.Jul 2 2019, 01:16

This is not complete, I am seeing some weird behaviour.

markblundeberg added inline comments.Jul 2 2019, 04:00
test/functional/p2p_invalid_block.py
116 ↗(On Diff #9898)

Note this additional yield has been removed (where the correct block is sent)... Core doesn't have this and it's not needed.

deadalnix accepted this revision.Jul 3 2019, 13:46
This revision is now accepted and ready to land.Jul 3 2019, 13:46
markblundeberg updated this revision to Diff 9958.EditedJul 3 2019, 14:55

rebase (I rebase-conflicted myself with D3527, which (in the original PR) removes the "Verify valid transaction" test case added here... :facepalm:)