Page MenuHomePhabricator
Create Task
Maniphest T669

Removing comparison test framework
Closed, ResolvedPublic
Actions

Description

See: https://github.com/bitcoin/bitcoin/issues/10603

Convert bip65-cltv-p2p.py to use the BitcoinTestFramework (#10695)
Convert bipdersig-p2p.py to use the BitcoinTestFramework (#10695)
Convert invalidtxrequest.py to use the BitcoinTestFramework (#11771)
Convert p2p_invalid_block.py to use the BitcoinTestFramework (#11772)
Convert feature_block.py to use the BitcoinTestFramework (#11773)
Convert feature_csv_activation.py to use the BitcoinTestFramework (#11817)
Delete redundant feature_bip9_softforks.py (#11818)
Remove the ComparisonTestFramework code (#11818)

In addition ABC has a number of tests unfortunately built using comptool:
abc-invalid-chains.py
abc-mempool-accept-txn.py
abc-mempool-coherence-on-activations.py
abc-p2p-compactblocks.py
abc-p2p-fullblocktest.py
abc-replay-protection.py
abc-schnorr.py
abc-segwit-recovery.py
abc-transaction-ordering.py

Revisions and Commits

rABC Bitcoin ABC
ClosedD3996 Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework
ClosedD3995 Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework
ClosedD3991 Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework
ClosedD3990 Migrated abc-transaction-ordering.py off of ComparisonTestFramework
ClosedD3562 [tests] fix flake8 nits in feature_csv_activation.py
ClosedD3561 [tests] Change feature_csv_activation.py to use BitcoinTestFramework
ClosedD3560 Move utility functions in feature_csv_activation.py out of class.
ClosedD3559 [tests] Remove nested loops from feature_csv_activation.py
ClosedD3558 [tests] improve logging in feature_csv_activation.py
ClosedD3514 Merge #11773: [tests] Change feature_block.py to use BitcoinTestFramework
ClosedD3511 Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework
ClosedD1064 [qa] Rewrite BIP65/BIP66 functional tests
ClosedD3494 Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework

Related Objects
Search...

Event Timeline

markblundeberg created this task.Jul 1 2019, 06:09
markblundeberg added a revision: D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.Jul 1 2019, 15:03
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCd1c4b8b1c40c: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.Jul 1 2019, 20:21
markblundeberg added a comment.Jul 1 2019, 20:29

(After this, can port in https://github.com/bitcoin/bitcoin/pull/13512/files and https://github.com/bitcoin/bitcoin/pull/13517/files which are pretty great... )

markblundeberg added a revision: D1064: [qa] Rewrite BIP65/BIP66 functional tests.Jul 1 2019, 20:59
markblundeberg added a revision: D3511: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.Jul 2 2019, 04:01
markblundeberg added a revision: D3514: Merge #11773: [tests] Change feature_block.py to use BitcoinTestFramework.Jul 2 2019, 06:37
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC2e1d21e29394: Merge #11773: [tests] Change feature_block.py to use BitcoinTestFramework.Jul 3 2019, 14:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.Jul 3 2019, 15:15
markblundeberg added a revision: D3558: [tests] improve logging in feature_csv_activation.py.Jul 5 2019, 12:56
markblundeberg added a revision: D3559: [tests] Remove nested loops from feature_csv_activation.py.
markblundeberg added a revision: D3560: Move utility functions in feature_csv_activation.py out of class..
markblundeberg added a revision: D3561: [tests] Change feature_csv_activation.py to use BitcoinTestFramework.
markblundeberg added a revision: D3562: [tests] fix flake8 nits in feature_csv_activation.py.
markblundeberg updated the task description. (Show Details)Jul 5 2019, 13:33
Fabien mentioned this in rABC87cc1b1d23d7: [tests] improve logging in feature_csv_activation.py.Jul 5 2019, 13:34
Fabien mentioned this in rABC68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py.Jul 5 2019, 13:37
Fabien mentioned this in rABCaae5372964bc: Move utility functions in feature_csv_activation.py out of class..
Fabien mentioned this in rABC8ccc74759c54: [tests] Change feature_csv_activation.py to use BitcoinTestFramework.Jul 5 2019, 13:39
Fabien mentioned this in rABCa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py.
jasonbcox added a subscriber: jasonbcox.Jul 25 2019, 22:59
In T669#8822, @markblundeberg wrote:

(After this, can port in https://github.com/bitcoin/bitcoin/pull/13512/files and https://github.com/bitcoin/bitcoin/pull/13517/files which are pretty great... )

I started working on these and realized it depends on this task. I've created tasks for them and linked them to this one.

jasonbcox triaged this task as High priority.Jul 25 2019, 22:59
jasonbcox added a parent task: T679: Backport Core PR 13512.
jasonbcox mentioned this in D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.Aug 13 2019, 00:51
jasonbcox mentioned this in D3890: Migrate abc-mempool-accept-txn.py off of ComparisonTestFramework.Aug 15 2019, 23:35
jasonbcox mentioned this in D3892: Migrated abc-replay-protection off of ComparisonTestFramework.Aug 16 2019, 00:37
jasonbcox mentioned this in rABC93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework.Aug 16 2019, 23:44
jasonbcox mentioned this in rABC5464053453af: Migrate abc-mempool-accept-txn.py off of ComparisonTestFramework.Aug 16 2019, 23:47
jasonbcox mentioned this in rABC6126bec0bcd9: Migrated abc-replay-protection off of ComparisonTestFramework.
jasonbcox added a revision: D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.Sep 4 2019, 14:39
jasonbcox mentioned this in D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
jasonbcox added a revision: D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.Sep 4 2019, 14:51
jasonbcox mentioned this in D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
jasonbcox added a revision: D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.Sep 4 2019, 16:06
jasonbcox mentioned this in D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
jasonbcox added a revision: D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.Sep 4 2019, 18:21
jasonbcox mentioned this in D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
jasonbcox mentioned this in rABCa6e32827ea6a: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.Sep 5 2019, 15:22
jasonbcox mentioned this in rABC30ad164a8285: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
jasonbcox mentioned this in rABC2557eb97aa72: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
jasonbcox mentioned this in rABC23dd085f1312: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.Sep 5 2019, 15:25
jasonbcox mentioned this in D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].Sep 5 2019, 15:41
jasonbcox mentioned this in rABC7fe97790bd89: Merge #11818: I accidentally [deliberately] killed it [the….Sep 6 2019, 15:42
jasonbcox closed this task as Resolved.Sep 6 2019, 15:42
jasonbcox claimed this task.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGd1c4b8b1c40c: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.Sep 19 2019, 00:49
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING2e1d21e29394: Merge #11773: [tests] Change feature_block.py to use BitcoinTestFramework.Sep 19 2019, 00:53
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING6965c1646e69: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.
Fabien mentioned this in rSTAGING87cc1b1d23d7: [tests] improve logging in feature_csv_activation.py.Sep 19 2019, 00:56
Fabien mentioned this in rSTAGINGaae5372964bc: Move utility functions in feature_csv_activation.py out of class..
Fabien mentioned this in rSTAGING68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py.
Fabien mentioned this in rSTAGING8ccc74759c54: [tests] Change feature_csv_activation.py to use BitcoinTestFramework.
Fabien mentioned this in rSTAGINGa3ec7ccdd58f: [tests] fix flake8 nits in feature_csv_activation.py.
jasonbcox mentioned this in rSTAGING93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework.Sep 19 2019, 01:53
jasonbcox mentioned this in rSTAGING5464053453af: Migrate abc-mempool-accept-txn.py off of ComparisonTestFramework.
jasonbcox mentioned this in rSTAGING6126bec0bcd9: Migrated abc-replay-protection off of ComparisonTestFramework.
jasonbcox mentioned this in rSTAGINGa6e32827ea6a: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.Sep 19 2019, 02:07
jasonbcox mentioned this in rSTAGING30ad164a8285: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
jasonbcox mentioned this in rSTAGING2557eb97aa72: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
jasonbcox mentioned this in rSTAGING23dd085f1312: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
jasonbcox mentioned this in rSTAGING7fe97790bd89: Merge #11818: I accidentally [deliberately] killed it [the….Sep 19 2019, 02:10