Page MenuHomePhabricator
Differential D3559

[tests] Remove nested loops from feature_csv_activation.py
ClosedPublic
Actions

Authored by Fabien on Jul 5 2019, 12:13.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Project
Maniphest Tasks
T669: Removing comparison test framework
Commits
rSTAGING68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py
rABC68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py
Summary

Makes the test a lot clearer.

Partial backport of core PR11817 (commit 0842edf)
https://github.com/bitcoin/bitcoin/pull/11817/commits/0842edf9ee7d659408e48b8897ac4a272e48b716

Depends on D3558

Test Plan
./test/functional/test_runner.py feature_csv_activation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 5 2019, 12:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2019, 12:13
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 5 2019, 12:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 5 2019, 12:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6677: Diff 9993.Jul 5 2019, 12:19
Fabien updated this revision to Diff 9994.Jul 5 2019, 12:22

Restore #124 test numbering.

teamcity added a comment.Jul 5 2019, 12:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3560: Move utility functions in feature_csv_activation.py out of class..Jul 5 2019, 12:25
teamcity added a comment.Jul 5 2019, 12:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6678: Diff 9994.Jul 5 2019, 12:28
markblundeberg added a task: T669: Removing comparison test framework.Jul 5 2019, 12:56
markblundeberg accepted this revision.Jul 5 2019, 13:17
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
test/functional/feature_csv_activation.py
196 ↗(On Diff #9994)

Original PR has "Returns a list of bip68 transactions with different bits set." but I guess this is more correct.

626 ↗(On Diff #9994)

interesting, I guess out of order backport

This revision is now accepted and ready to land.Jul 5 2019, 13:17
Closed by commit rABC68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJul 5 2019, 13:37
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py.
Fabien added a commit: rSTAGING68e1fa6c419f: [tests] Remove nested loops from feature_csv_activation.py.Sep 19 2019, 00:56

Revision Contents
Changeset List

PathSize
test/
functional/
266 lines

Diff 10001

View Options

test/functional/feature_csv_activation.py

Loading...