Page MenuHomePhabricator

[tests] Remove nested loops from feature_csv_activation.py
ClosedPublic

Authored by Fabien on Jul 5 2019, 12:13.

Details

Summary

Makes the test a lot clearer.

Partial backport of core PR11817 (commit 0842edf)
https://github.com/bitcoin/bitcoin/pull/11817/commits/0842edf9ee7d659408e48b8897ac4a272e48b716

Depends on D3558

Test Plan
./test/functional/test_runner.py feature_csv_activation

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11817_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6677
Build 11401: Bitcoin ABC Buildbot (legacy)
Build 11400: arc lint + arc unit

Event Timeline

Restore #124 test numbering.

markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
test/functional/feature_csv_activation.py
196 ↗(On Diff #9994)

Original PR has "Returns a list of bip68 transactions with different bits set." but I guess this is more correct.

626 ↗(On Diff #9994)

interesting, I guess out of order backport

This revision is now accepted and ready to land.Jul 5 2019, 13:17