Page MenuHomePhabricator

Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework]

Authored by jasonbcox on Thu, Sep 5, 15:41.



9c92c8c827 [tests] Remove Comparison Test Framework (John Newbery)
e80c640d78 [tests] Remove (John Newbery)

Pull request description:

Builds on #11772, #11773 and #11817. Please review those PRs first.

Final step in #10603.

- First commit removes was intended to be a generic test for versionbits deployments. However, it only tests CSV activation and was not updated to test segwit activation. CSV activation is tested by, so this test is duplicated effort. Rather than try to update it to use the BitcoinTestFramework, just remove it. (see for previous discussion around the redundancy of
- Second commit removes the now unused BitcoinComparisonFramework class and the comptool and blockstore modules.

Tree-SHA512: 4bb7196d521048b3b8ba95c87dde73005a1ac73d29ccbb869f11ce9a71089686e7eacd7335337853041dfbd3a5b110172b105adbada58779814d4db22b1376f5

Backport of Core PR11818

Completes T669

Test Plan

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Thu, Sep 5, 15:41
jasonbcox added inline comments.Thu, Sep 5, 15:42
1 ↗(On Diff #11099)

Macro itsoveritsdone:

Fabien requested changes to this revision.Thu, Sep 5, 18:10
Fabien added a subscriber: Fabien.
Fabien added inline comments.
340 ↗(On Diff #11099)

Kill'em all !

346 ↗(On Diff #11099)

Kill'em all !

This revision now requires changes to proceed.Thu, Sep 5, 18:10
jasonbcox updated this revision to Diff 11117.Fri, Sep 6, 00:27

Cleaned up remaining doc notes

Fabien accepted this revision.Fri, Sep 6, 06:01
This revision is now accepted and ready to land.Fri, Sep 6, 06:01