HomePhabricator

Merge #11818: I accidentally [deliberately] killed it [the…

Description

Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework]

Summary:
9c92c8c827 [tests] Remove Comparison Test Framework (John Newbery)
e80c640d78 [tests] Remove bip9-softforks.py (John Newbery)

Pull request description:

Builds on #11772, #11773 and #11817. Please review those PRs first.

Final step in #10603.

- First commit removes bip9-softforks.py.  bip9-sofforks.py was intended to be a generic test for versionbits deployments. However, it only tests CSV activation and was not updated to test segwit activation. CSV activation is tested by bip68-112-113-p2p.py, so this test is duplicated effort. Rather than try to update it to use the BitcoinTestFramework, just remove it. (see https://github.com/btcdrak/bitcoin/pull/8 for previous discussion around the redundancy of bip9-softforks.py)
- Second commit removes the now unused BitcoinComparisonFramework class and the comptool and blockstore modules.

Tree-SHA512: 4bb7196d521048b3b8ba95c87dde73005a1ac73d29ccbb869f11ce9a71089686e7eacd7335337853041dfbd3a5b110172b105adbada58779814d4db22b1376f5

Backport of Core PR11818
https://github.com/bitcoin/bitcoin/pull/11818/files

Completes T669

Test Plan: test_runner.py

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4002

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Sep 5 2019, 15:31
jasonbcoxCommitted on Sep 6 2019, 15:42
jasonbcoxPushed on Sep 6 2019, 16:45
Reviewer
Restricted Project
Differential Revision
D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework]
Parents
rSTAGINGad3f7f55012f: Merge #13512: [qa] mininode: Expose connection state through is_connected
Branches
Unknown
Tags
Unknown