Page MenuHomePhabricator

Migrate abc-invalid-chains off of the ComparisonTestFramework
ClosedPublic

Authored by jasonbcox on Mon, Aug 12, 23:18.

Details

Summary

See title.

Depends on D3862 due to a difficult to pinpoint robustness issue without that change.
Rather than attempt to solve the issue, we can get rid of it entirely by backporting D3862 first.

Progress towards T669

Test Plan

test_runner.py abc-invalid-chains

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Aug 12, 23:18
jasonbcox edited the summary of this revision. (Show Details)Tue, Aug 13, 00:51
Fabien requested changes to this revision.Tue, Aug 13, 07:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc-invalid-chains.py
46 ↗(On Diff #10748)

Nit: the name is confusing because sync_blocks() is already defined by the test_framework (twice...).

This revision now requires changes to proceed.Tue, Aug 13, 07:49
jasonbcox added inline comments.Wed, Aug 14, 22:46
test/functional/abc-invalid-chains.py
46 ↗(On Diff #10748)

I further realized after copying this over from Core's tests, that this intermediate function isn't necessary in this test since there's no reconnecting going on. I'll just remove it entirely.

jasonbcox updated this revision to Diff 10801.Wed, Aug 14, 22:53

Cleanup unnecessary and confusing sync_blocks function.

Fabien accepted this revision.Fri, Aug 16, 08:00
This revision is now accepted and ready to land.Fri, Aug 16, 08:00