Migrate abc-invalid-chains off of the ComparisonTestFramework
ClosedPublic
Actions

Authored by jasonbcox on Aug 12 2019, 23:18.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework
rABC93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework

Summary

See title.

Depends on D3862 due to a difficult to pinpoint robustness issue without that change.
Rather than attempt to solve the issue, we can get rid of it entirely by backporting D3862 first.

Progress towards T669

Test Plan

test_runner.py abc-invalid-chains

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Aug 12 2019, 23:18

Herald added a reviewer: deadalnix. · View Herald TranscriptAug 12 2019, 23:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox mentioned this in D3862: qa: Read reject reasons from debug log, not p2p messages.Aug 12 2019, 23:19

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7129: Diff 10748!Aug 12 2019, 23:23

jasonbcox edited the summary of this revision. (Show Details)Aug 13 2019, 00:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7129: Diff 10748.Aug 13 2019, 01:19

Fabien requested changes to this revision.Aug 13 2019, 07:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/abc-invalid-chains.py
46 ↗	(On Diff #10748)	Nit: the name is confusing because `sync_blocks()` is already defined by the test_framework (twice...).

This revision now requires changes to proceed.Aug 13 2019, 07:49

jasonbcox mentioned this in rABCea63c14f0d04: qa: Read reject reasons from debug log, not p2p messages.Aug 14 2019, 16:39

jasonbcox added inline comments.Aug 14 2019, 22:46

test/functional/abc-invalid-chains.py
46 ↗	(On Diff #10748)	I further realized after copying this over from Core's tests, that this intermediate function isn't necessary in this test since there's no reconnecting going on. I'll just remove it entirely.