Page MenuHomePhabricator
Differential D3863

Migrate abc-invalid-chains off of the ComparisonTestFramework
ClosedPublic
Actions

Authored by jasonbcox on Aug 12 2019, 23:18.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework
rABC93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework
Summary

See title.

Depends on D3862 due to a difficult to pinpoint robustness issue without that change.
Rather than attempt to solve the issue, we can get rid of it entirely by backporting D3862 first.

Progress towards T669

Test Plan

test_runner.py abc-invalid-chains

Diff Detail

Repository
rABC Bitcoin ABC
Branch
invalid-chains-comptool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7129
Build 12304: Bitcoin ABC Buildbot (legacy)
Build 12303: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 12 2019, 23:18
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 12 2019, 23:18
teamcity added a comment.Aug 12 2019, 23:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox mentioned this in D3862: qa: Read reject reasons from debug log, not p2p messages.Aug 12 2019, 23:19
teamcity added a comment.Aug 12 2019, 23:23

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7129: Diff 10748!Aug 12 2019, 23:23
jasonbcox edited the summary of this revision. (Show Details)Aug 13 2019, 00:51
teamcity added a comment.Aug 13 2019, 01:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 01:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7129: Diff 10748.Aug 13 2019, 01:19
Fabien requested changes to this revision.Aug 13 2019, 07:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc-invalid-chains.py
46

Nit: the name is confusing because sync_blocks() is already defined by the test_framework (twice...).

This revision now requires changes to proceed.Aug 13 2019, 07:49
jasonbcox mentioned this in rABCea63c14f0d04: qa: Read reject reasons from debug log, not p2p messages.Aug 14 2019, 16:39
jasonbcox added inline comments.Aug 14 2019, 22:46
test/functional/abc-invalid-chains.py
46

I further realized after copying this over from Core's tests, that this intermediate function isn't necessary in this test since there's no reconnecting going on. I'll just remove it entirely.

jasonbcox updated this revision to Diff 10801.Aug 14 2019, 22:53

Cleanup unnecessary and confusing sync_blocks function.

teamcity added a comment.Aug 14 2019, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 14 2019, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7155: Diff 10801!Aug 14 2019, 22:55
teamcity added a comment.Aug 14 2019, 23:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 14 2019, 23:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7155: Diff 10801.Aug 14 2019, 23:12
Fabien accepted this revision.Aug 16 2019, 08:00
This revision is now accepted and ready to land.Aug 16 2019, 08:00
Closed by commit rABC93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework (authored by jasonbcox). · Explain WhyAug 16 2019, 23:44
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework.
jasonbcox mentioned this in rSTAGINGea63c14f0d04: qa: Read reject reasons from debug log, not p2p messages.Sep 19 2019, 01:49
jasonbcox added a commit: rSTAGING93ba8ba77b48: Migrate abc-invalid-chains off of the ComparisonTestFramework.Sep 19 2019, 01:53

Revision Contents
Changeset List

PathSize
test/
functional/
80 lines

Diff 10748

View Options

test/functional/abc-invalid-chains.py

Loading...