Page MenuHomePhabricator

Merge #14101: qa: Use named args in validation acceptance tests
ClosedPublic

Authored by jasonbcox on Mon, Aug 12, 22:59.

Details

Summary

fa782a308dbe7bc579c122f63c1c65666fc85e91 qa: Use named args in some tests (MarcoFalke)
b4d33096734d787b0e1d754064039cbb64ce8d61 scripted-diff: Use named arguments in feature_block (MarcoFalke)
749ba35e7c9fbc21dbea27fd1be102b91313d132 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke)

Pull request description:

It is confusing to use a list of arguments such as `False, False, 16, ...` where it is unclear what each of them means.

Run some scripted diffs to put meaning to them.

Tree-SHA512: d768df2375ea3c77145ebb1bf4c2d690581a379031449ded7ae160022d975eb13890aa8c6a44a5eebda8791cb2910a599326e431af76ed9e60afe1d182ada65c

Backport of Core PR14101
https://github.com/bitcoin/bitcoin/pull/14101/files

Reviewer note: mining_basic.py was skipped because that section of code has not been backported yet.
The dependency chain for backporting that section of code is complex and depends on deprecation of
the ComparisonTestFramework. It's a trivial change to patch on later, so it can be skipped here.

Test Plan
test_runner.py feature_block
test_runner.py p2p_invalid_block

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Aug 12, 22:59
Fabien added a subscriber: Fabien.Tue, Aug 13, 07:21

Mind backporting the dependency for mining_basic.py ? https://github.com/bitcoin/bitcoin/pull/13399/files

Fabien accepted this revision.Wed, Aug 14, 07:41

NVM my previous comment, I missed you pointed this out in the summary.

This revision is now accepted and ready to land.Wed, Aug 14, 07:41