HomePhabricator

Merge #14101: qa: Use named args in validation acceptance tests

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Aug 31 2018, 11:07.

Description

Merge #14101: qa: Use named args in validation acceptance tests

Summary:
fa782a308dbe7bc579c122f63c1c65666fc85e91 qa: Use named args in some tests (MarcoFalke)
b4d33096734d787b0e1d754064039cbb64ce8d61 scripted-diff: Use named arguments in feature_block (MarcoFalke)
749ba35e7c9fbc21dbea27fd1be102b91313d132 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke)

Pull request description:

It is confusing to use a list of arguments such as `False, False, 16, ...` where it is unclear what each of them means.

Run some scripted diffs to put meaning to them.

Tree-SHA512: d768df2375ea3c77145ebb1bf4c2d690581a379031449ded7ae160022d975eb13890aa8c6a44a5eebda8791cb2910a599326e431af76ed9e60afe1d182ada65c

Backport of Core PR14101
https://github.com/bitcoin/bitcoin/pull/14101/files

Reviewer note: mining_basic.py was skipped because that section of code has not been backported yet.
The dependency chain for backporting that section of code is complex and depends on deprecation of
the ComparisonTestFramework. It's a trivial change to patch on later, so it can be skipped here.

Test Plan:

test_runner.py feature_block
test_runner.py p2p_invalid_block

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3861

Details

Committed
jasonbcoxAug 14 2019, 16:31
Pushed
jasonbcoxAug 14 2019, 16:31
Reviewer
Restricted Project
Differential Revision
D3861: Merge #14101: qa: Use named args in validation acceptance tests
Parents
rABCe6eac5abd906: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file
Branches
Unknown
Tags
Unknown