Merge #13003: qa: Add test for orphan handling
ClosedPublic
Actions

Authored by markblundeberg on Jul 2 2019, 19:50.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGd31648b229fa: Merge #13003: qa: Add test for orphan handling
rABCd31648b229fa: Merge #13003: qa: Add test for orphan handling

Summary

PR13003 backport https://github.com/bitcoin/bitcoin/pull/13003/files
fa02c5b qa: Clarify documentation for send_txs_and_test (MarcoFalke)
fadfbd3 qa: Add test for orphan handling (MarcoFalke)

Backport note: needed pad_tx for these

Depends on D3514

Test Plan

test_runner.py p2p_invalid_tx.py
test_runner.py feature_block.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13003

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6634
Build 11315: Bitcoin ABC Buildbot (legacy)
Build 11314: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 2 2019, 19:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 19:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Note that this removes -whitelist , and adds this expect_disconnect feature. This is will let us do nicer tests of transaction banning/non-banning for mandatory flags.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6634: Diff 9926.Jul 2 2019, 19:56

deadalnix accepted this revision.Jul 3 2019, 13:11

This revision is now accepted and ready to land.Jul 3 2019, 13:11

Closed by commit rABCd31648b229fa: Merge #13003: qa: Add test for orphan handling (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 3 2019, 14:48

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCd31648b229fa: Merge #13003: qa: Add test for orphan handling.

markblundeberg mentioned this in D3511: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.Jul 3 2019, 14:55

markblundeberg added inline comments.Jul 3 2019, 15:03

test/functional/p2p_invalid_tx.py
61 ↗	(On Diff #9957)	This was supposed to be removing "# Verify valid transaction ..." that would have been added in D3511, but I mistakenly backported out of order. Will be resynced after D3511 lands.