Page MenuHomePhabricator

Merge #13048: [tests] Fix feature_block flakiness
ClosedPublic

Authored by markblundeberg on Jul 2 2019, 20:34.

Details

Summary

PR13048 backport https://github.com/bitcoin/bitcoin/pull/13048/files
c1d742025c [tests] Fix feature_block flakiness (John Newbery)

Pull request description:

feature_block.py occasionally fails on Travis. I believe this is due to
a a race condition when reconnecting to bitcoind after a subtest that
expects disconnection. If the test runs ahead and sends the INV for the
subsequent test before we've received the initial sync getheaders, then
we may end up sending two headers messages - one as a response to the
initial sync getheaders and one in response to the INV getheaders. If
both of those headers fail validation with a DoS score of 50 or higher,
then we'll unexpectedly be disconnected.

There is only one validation failure that has a DoS score bewteen 50 and
100, which is high-hash. That's why the test is failing immediately
after the "Reject a block with invalid work" subtest.

Fix is to wait for the initial getheaders from the peer before we
start populating our blockstore. That way we won't have any invalid
headers to respond to it with.

Depends on D3514

Test Plan

./test/functional/test_runner.py feature_block.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 2 2019, 20:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 20:34
deadalnix requested changes to this revision.Jul 3 2019, 02:27

The description is fubared

This revision now requires changes to proceed.Jul 3 2019, 02:27
markblundeberg requested review of this revision.Jul 3 2019, 02:57
markblundeberg edited the summary of this revision. (Show Details)

The description is fubared

Sorry about that!

deadalnix accepted this revision.Jul 3 2019, 13:14
This revision is now accepted and ready to land.Jul 3 2019, 13:14