HomePhabricator

build: Windows SSP roundup

Description

build: Windows SSP roundup

Summary:

I was expecting this to fail to compile somewhere, maybe in the CI, but that doesn't seem to be the case?
Seems workable given the SSP related changes in the newer mingw-w64 headers (which are in Guix):

    Implement some of the stack protector functions/variables so -lssp is now optional when _FORTIFY_SOURCE or -fstack-protector-strong is used.

However I think this would still be broken in some older environments, so we might have to wait for a compiler bump, or similar. The optional -lssp also seems to work when using older headers, which doesn't make sense.

Backport of core#28461.

Test Plan: Run the GUIX windows build

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17229

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Sep 12 2023, 13:38
FabienCommitted on Fri, Nov 29, 08:39
FabienPushed on Fri, Nov 29, 08:39
Reviewer
Restricted Project
Differential Revision
D17229: build: Windows SSP roundup
Parents
rABC10076c2a2034: [chronik] updated dependencies - Cargo.lock
Branches
Unknown
Tags
Unknown