HomePhabricator

[refactor multisig] move nulldummy check to front

Description

[refactor multisig] move nulldummy check to front

Summary:
Note that this is a behavioural change for the error reason of some
transactions, where there are multiple reasons for failure. We do not
however test for such multi-failure scenarios, anywhere.

For example, a multisig spend with both non-null dummy and fail with
non-null signatures in it previously would give
"mandatory-script-verify-flag-failed (..nullfail reason..)",
but now would give
"mandatory-script-verify-flag-failed (..nulldummy reason..)".

Depends on D3625

Test Plan:
make check
test_runner.py

Reviewers: deadalnix, Mengerian, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3673

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jul 14 2019, 00:29
markblundebergPushed on Jul 15 2019, 00:52
Reviewer
Restricted Project
Differential Revision
D3673: [refactor multisig] move nulldummy check to front
Parents
rABC5e82569b10e0: [refactor multisig] make const values up front
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCce93d43bd963: [refactor multisig] move nulldummy check to front (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jul 15 2019, 00:52