Page MenuHomePhabricator

[refactor multisig] move nulldummy check to front
ClosedPublic

Authored by markblundeberg on Jul 14 2019, 00:37.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rABCce93d43bd963: [refactor multisig] move nulldummy check to front
Summary

Note that this is a behavioural change for the error reason of some
transactions, where there are multiple reasons for failure. We do not
however test for such multi-failure scenarios, anywhere.

For example, a multisig spend with both non-null dummy and fail with
non-null signatures in it previously would give
"mandatory-script-verify-flag-failed (..nullfail reason..)",
but now would give
"mandatory-script-verify-flag-failed (..nulldummy reason..)".

Depends on D3625

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.