Page MenuHomePhabricator

[refactor multisig] separate nullfail from stack cleanup
ClosedPublic

Authored by markblundeberg on Jul 10 2019, 01:38.

Details

Summary

Currently, some rule checks are integrated into the stack cleanup
process, resulting in some obfuscated-looking behaviour.

This moves the stack cleanup to the very end, once all operations
have completed, including nullfail and the dummy element check.

Depends on D3673

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 10 2019, 01:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 01:38
deadalnix added inline comments.Jul 10 2019, 02:32
src/script/interpreter.cpp
1081 ↗(On Diff #10179)

That guy should probably be moved up front. You wouldn't have to modify it here if you do it first.

markblundeberg planned changes to this revision.Jul 10 2019, 15:49
markblundeberg edited the summary of this revision. (Show Details)

reworked parents

deadalnix accepted this revision.Jul 14 2019, 17:06
This revision is now accepted and ready to land.Jul 14 2019, 17:06