HomePhabricator

[refactor multisig] separate nullfail from stack cleanup

Description

[refactor multisig] separate nullfail from stack cleanup

Summary:
Currently, some rule checks are integrated into the stack cleanup
process, resulting in some obfuscated-looking behaviour.

This moves the stack cleanup to the very end, once all operations
have completed, including nullfail and the dummy element check.

Depends on D3673

Test Plan: make check

Reviewers: deadalnix, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3626

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jul 10 2019, 01:33
markblundebergPushed on Jul 15 2019, 00:53
Reviewer
Restricted Project
Differential Revision
D3626: [refactor multisig] separate nullfail from stack cleanup
Parents
rABCce93d43bd963: [refactor multisig] move nulldummy check to front
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC10b29ca11538: [refactor multisig] separate nullfail from stack cleanup (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jul 15 2019, 00:53