Page MenuHomePhabricator

[refactor multisig] separate nullfail from stack cleanup
ClosedPublic

Authored by markblundeberg on Jul 10 2019, 01:38.

Details

Summary

Currently, some rule checks are integrated into the stack cleanup
process, resulting in some obfuscated-looking behaviour.

This moves the stack cleanup to the very end, once all operations
have completed, including nullfail and the dummy element check.

Depends on D3673

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rms1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6785
Build 11617: Bitcoin ABC Buildbot (legacy)
Build 11616: arc lint + arc unit

Event Timeline

src/script/interpreter.cpp
1081

That guy should probably be moved up front. You wouldn't have to modify it here if you do it first.

This revision is now accepted and ready to land.Jul 14 2019, 17:06