Remove unused raw-pointer read helper from univalue
d3460c587e60
Actions

Description

Remove unused raw-pointer read helper from univalue

Summary:

The helpers are unused outside of tests and redundant with the existing bool read(std::string_view raw);.

Fix both issues by removing them.

Also, simplify the tests code by removing a std::string constructor where possible.

Backport of core#28168.

Depends on D16295.

Test Plan:

ninja all check

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16296

Details

Provenance

MarcoFalke <*~=`'#}+{/-\|&$^_@721217.xyz>	Authored on Jul 27 2023, 10:17
Fabien	Committed on Thu, Jun 6, 10:38
Fabien	Pushed on Thu, Jun 6, 10:38

Reviewer

Restricted Project

Differential Revision

D16296: Remove unused raw-pointer read helper from univalue

Parents

rABCdafdf07d9791: scripted-diff: Following the C++ Standard rules for identifiers with _.

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABCd3460c587e60: Remove unused raw-pointer read helper from univalue (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).Thu, Jun 6, 10:38

Fabien added an edge: D16296: Remove unused raw-pointer read helper from univalue.

Changes (11)

Path

Size

src/

test/

base58_tests.cpp

blockfilter_tests.cpp

data/

transaction_tests.cpp

univalue/

include/

univalue.h

lib/

univalue_read.cpp

test/

unitester.cpp

rABCd3460c587e60

View Options

src/test/base58_tests.cpp

View Options

src/test/blockfilter_tests.cpp

View Options

src/test/data/generate_header.py

View Options

src/test/key_io_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/univalue/include/univalue.h

View Options

src/univalue/lib/univalue_read.cpp

View Options

src/univalue/test/unitester.cpp

Remove unused raw-pointer read helper from univalued3460c587e60Actions

Description

Details

Event Timeline

Changes (11)

rABCd3460c587e60

src/test/base58_tests.cpp

src/test/blockfilter_tests.cpp

src/test/data/generate_header.py

src/test/key_io_tests.cpp

src/test/rpc_tests.cpp

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/transaction_tests.cpp

src/univalue/include/univalue.h

src/univalue/lib/univalue_read.cpp

src/univalue/test/unitester.cpp

Remove unused raw-pointer read helper from univalue
d3460c587e60
Actions