Differential D16296

Remove unused raw-pointer read helper from univalue
ClosedPublic
Actions

Authored by Fabien on Wed, Jun 5, 21:31.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd3460c587e60: Remove unused raw-pointer read helper from univalue

Summary

The helpers are unused outside of tests and redundant with the existing bool read(std::string_view raw);.

Fix both issues by removing them.

Also, simplify the tests code by removing a std::string constructor where possible.

Backport of core#28168.

Depends on D16295.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Jun 5, 21:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 5, 21:31

Fabien requested review of this revision.Wed, Jun 5, 21:31

teamcity edited the summary of this revision. (Show Details)Wed, Jun 5, 21:32

Harbormaster completed remote builds in B29239: Diff 48137.Wed, Jun 5, 21:50

Fabien added a child revision: D16297: test: Fix failing univalue float test.Wed, Jun 5, 21:57

PiRK accepted this revision.Thu, Jun 6, 07:06

This revision is now accepted and ready to land.Thu, Jun 6, 07:06

Closed by commit rABCd3460c587e60: Remove unused raw-pointer read helper from univalue (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by Fabien). · Explain WhyThu, Jun 6, 10:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd3460c587e60: Remove unused raw-pointer read helper from univalue.

Revision Contents
Changeset List

Path

Size

src/

test/

base58_tests.cpp

10 lines

blockfilter_tests.cpp

5 lines

data/

4 lines

12 lines

2 lines

8 lines

4 lines

transaction_tests.cpp

8 lines

univalue/

include/

univalue.h

8 lines

lib/

univalue_read.cpp

8 lines

test/

unitester.cpp

2 lines

Diff 48157

View Options

src/test/base58_tests.cpp

View Options

src/test/blockfilter_tests.cpp

View Options

src/test/data/generate_header.py

View Options

src/test/key_io_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/univalue/include/univalue.h

View Options

src/univalue/lib/univalue_read.cpp

View Options

src/univalue/test/unitester.cpp

Remove unused raw-pointer read helper from univalueClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48157

src/test/base58_tests.cpp

src/test/blockfilter_tests.cpp

src/test/data/generate_header.py

src/test/key_io_tests.cpp

src/test/rpc_tests.cpp

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/transaction_tests.cpp

src/univalue/include/univalue.h

src/univalue/lib/univalue_read.cpp

src/univalue/test/unitester.cpp

Remove unused raw-pointer read helper from univalue
ClosedPublic
Actions

Revision Contents
Changeset List