Page MenuHomePhabricator
Differential D16296

Remove unused raw-pointer read helper from univalue
ClosedPublic
Actions

Authored by Fabien on Jun 5 2024, 21:31.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCd3460c587e60: Remove unused raw-pointer read helper from univalue
Summary
The helpers are unused outside of tests and redundant with the existing bool read(std::string_view raw);.

Fix both issues by removing them.

Also, simplify the tests code by removing a std::string constructor where possible.

Backport of core#28168.

Depends on D16295.

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
test/
10 lines
5 lines
data/
4 lines
12 lines
2 lines
8 lines
4 lines
8 lines
univalue/
include/
8 lines
lib/
8 lines
test/
2 lines

Diff 48157

View Options

src/test/base58_tests.cpp

Loading...
View Options

src/test/blockfilter_tests.cpp

Loading...
View Options

src/test/data/generate_header.py

Loading...
View Options

src/test/key_io_tests.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/sighash_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/univalue/include/univalue.h

Loading...
View Options

src/univalue/lib/univalue_read.cpp

Loading...
View Options

src/univalue/test/unitester.cpp

Loading...