test: Fix failing univalue float test
ClosedPublic
Actions

Authored by Fabien on Jun 5 2024, 21:57.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6df79e2650a8: test: Fix failing univalue float test

Summary

Currently the test may fail for some compilers, because 1e-8 may not be possible to represent exactly/consistently.

Backport of core#29892.

Depends on D16296.

Test Plan

ninja check check-univalue

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 5 2024, 21:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 21:57

Fabien requested review of this revision.Jun 5 2024, 21:57

teamcity edited the summary of this revision. (Show Details)Jun 5 2024, 21:57

Harbormaster completed remote builds in B29240: Diff 48138.Jun 5 2024, 22:10

PiRK accepted this revision.Jun 6 2024, 07:08

This revision is now accepted and ready to land.Jun 6 2024, 07:08

Closed by commit rABC6df79e2650a8: test: Fix failing univalue float test (authored by Fabien). · Explain WhyJun 6 2024, 10:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6df79e2650a8: test: Fix failing univalue float test.

Revision Contents
Changeset List

Path

Size

src/

test/

rpc_tests.cpp

3 lines

univalue/

test/

object.cpp

2 lines

Diff 48158

View Options

src/test/rpc_tests.cpp