Page MenuHomePhabricator
Differential D16294

refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it
ClosedPublic
Actions

Authored by Fabien on Wed, Jun 5, 20:54.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC73b7a5561f53: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it
Summary
ParseNonRFCJSONValue() is no longer necessary and we can use UniValue::read() directly

[...]

To avoid code duplication, we keep the function to throw on invalid input data but rename it to Parse() and remove it from the header.

The existing test coverage we had on ParseNonRFCJSONValue() is moved over to UniValue::read().

Backport of core#27256.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Jun 5, 20:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 5, 20:54
Fabien requested review of this revision.Wed, Jun 5, 20:54
teamcity edited the summary of this revision. (Show Details)Wed, Jun 5, 20:54
Harbormaster completed remote builds in B29237: Diff 48135.Wed, Jun 5, 21:08
Fabien added a child revision: D16295: scripted-diff: Following the C++ Standard rules for identifiers with _..Wed, Jun 5, 21:08
PiRK requested changes to this revision.Thu, Jun 6, 07:01
PiRK added a subscriber: PiRK.

This is a partial backport. Did you skip the second commit intentionally?

This revision now requires changes to proceed.Thu, Jun 6, 07:01
Fabien added a comment.Thu, Jun 6, 09:25

No, that's a squash mistake, I will update

Fabien updated this revision to Diff 48152.Thu, Jun 6, 09:43
Fabien retitled this revision from test: move coverage on ParseNonRFCJSONValue() to UniValue::read() to refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it.
Fabien edited the summary of this revision. (Show Details)
Fabien removed a reviewer: PiRK.

Squash the 2 commits, update the summary

PiRK accepted this revision.Thu, Jun 6, 10:00
This revision is now accepted and ready to land.Thu, Jun 6, 10:00
Harbormaster completed remote builds in B29247: Diff 48152.Thu, Jun 6, 10:28
Closed by commit rABC73b7a5561f53: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it (authored by stickies-v <stickies-v@protonmail.com>, committed by Fabien). · Explain WhyThu, Jun 6, 10:29
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC73b7a5561f53: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it.

Revision Contents
Changeset List

PathSize
src/
rpc/
6 lines
35 lines
test/
fuzz/
7 lines
4 lines
44 lines
univalue/
test/
28 lines

Diff 48155

View Options

src/rpc/client.h

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/test/fuzz/parse_univalue.cpp

Loading...
View Options

src/test/fuzz/string.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...
View Options

src/univalue/test/object.cpp

Loading...