Differential D16289

univalue: Avoid std::string copies
ClosedPublic
Actions

Authored by Fabien on Jun 5 2024, 18:37.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC72a9f0336b08: univalue: Avoid std::string copies

Summary

This shouldn't matter too much, unless a really large string is pushed into a json struct, but I think it also clarifies the code.

Backport of core#25714.

Depends on D16285.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 5 2024, 18:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 18:37

Fabien requested review of this revision.Jun 5 2024, 18:37

teamcity edited the summary of this revision. (Show Details)Jun 5 2024, 18:37

Harbormaster completed remote builds in B29232: Diff 48130.Jun 5 2024, 19:19

Fabien added a child revision: D16290: rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR.Jun 5 2024, 19:34

PiRK accepted this revision.Jun 6 2024, 06:43

This revision is now accepted and ready to land.Jun 6 2024, 06:43

Closed by commit rABC72a9f0336b08: univalue: Avoid std::string copies (authored by MacroFake <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJun 6 2024, 09:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC72a9f0336b08: univalue: Avoid std::string copies.

Revision Contents
Changeset List

Path

Size

src/

univalue/

include/

6 lines

lib/

12 lines

test/

9 lines

Diff 48147

src/univalue/include/univalue.h

Loading...

src/univalue/lib/univalue.cpp

Loading...

src/univalue/test/object.cpp

Loading...