Differential D16288

Fix some std::move issues
ClosedPublic
Actions

Authored by Fabien on Wed, Jun 5, 18:11.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC54d457d91401: Fix some std::move issues

Summary

These moves are either:

copies because the variable being moved is const
references because the function parameter the var is moved to is a reference

Either fix by removing the constness or removing the move.
For the places where the move is removed, there is no performance impact as it was not working anyway.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Jun 5, 18:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 5, 18:11

Fabien requested review of this revision.Wed, Jun 5, 18:11

Fabien added a child revision: D16285: Fix issues when calling std::move(const&).Wed, Jun 5, 18:18

PiRK accepted this revision.Wed, Jun 5, 18:36

This revision is now accepted and ready to land.Wed, Jun 5, 18:36

Harbormaster completed remote builds in B29229: Diff 48127.Wed, Jun 5, 19:01

Closed by commit rABC54d457d91401: Fix some std::move issues (authored by Fabien). · Explain WhyWed, Jun 5, 22:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC54d457d91401: Fix some std::move issues.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

2 lines

test/

processor_tests.cpp

4 lines

bench/

chained_tx.cpp

4 lines

blockencodings.cpp

2 lines

net_processing.cpp

2 lines

rpc/

avalanche.cpp

5 lines

Diff 48140

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/bench/chained_tx.cpp

View Options

src/blockencodings.cpp

View Options

src/net_processing.cpp

View Options

Fix some std::move issuesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48140

src/avalanche/processor.cpp

src/avalanche/test/processor_tests.cpp

src/bench/chained_tx.cpp

src/blockencodings.cpp

src/net_processing.cpp

src/rpc/avalanche.cpp

Fix some std::move issues
ClosedPublic
Actions

Revision Contents
Changeset List