Page MenuHomePhabricator

Fix some std::move issues
ClosedPublic

Authored by Fabien on Jun 5 2024, 18:11.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC54d457d91401: Fix some std::move issues
Summary

These moves are either:

  • copies because the variable being moved is const
  • references because the function parameter the var is moved to is a reference

Either fix by removing the constness or removing the move.
For the places where the move is removed, there is no performance impact as it was not working anyway.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable