HomePhabricator

Fix some std::move issues

Description

Fix some std::move issues

Summary:
These moves are either:

  • copies because the variable being moved is const
  • references because the function parameter the var is moved to is a reference

Either fix by removing the constness or removing the move.
For the places where the move is removed, there is no performance impact as it was not working anyway.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16288

Details

Provenance
FabienAuthored on Wed, Jun 5, 18:08
FabienPushed on Wed, Jun 5, 22:22
Reviewer
Restricted Project
Differential Revision
D16288: Fix some std::move issues
Parents
rABCf011b1a31ba6: univalue: Remove unused and confusing set*() return value
Branches
Unknown
Tags
Unknown