HomePhabricator

Unsubtree Univalue

Description

Unsubtree Univalue

Summary:

With this PR I'm proposing we stop treating Univalue like a subtree, or upstream project/fork, and going forward, treat it as part of this codebase, which we can refactor directly (with pulls to this repo. Ideally, after this is merged, our univalue subtree repo could be marked as "archived". In this repo, I think there is a good chance that the Univalue code will ultimately be refactored away into "modern" C++, i.e using std::variant (at least one person has played around with doing this).

Backport of core#25369.

Depends on D16274.

For ease of review, only changes similar to the source material are included. However more changes will be added in follow-ups such as autotools removal and clang-format linting of the files.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16275

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Jun 10 2022, 14:30
FabienCommitted on Tue, Jun 4, 19:26
FabienPushed on Tue, Jun 4, 19:26
Reviewer
Restricted Project
Differential Revision
D16275: Unsubtree Univalue
Parents
rABCfc5c3a4e9f69: Bump univalue subtree
Branches
Unknown
Tags
Unknown

Event Timeline