HomePhabricator
Diffusion Bitcoin ABC d5489985e53c

Merge #12811: test: Make summary row bold-red if any test failed and show…
d5489985e53c
Actions

Description

Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table

Summary:
ffb033a test: List any failed tests at the end of test_runner output (Anthony Towns)
f92541f test: Make summary row bold-red if any test failed (Wladimir J. van der Laan)

Pull request description:

Make the summary row of the test runner bold red if *any* test fails. This helps visibility if something fails.
(yesteryday I had a snafu where I missed that `feature_blocksdir.py` had failed because it's one of the earlier tests in the list, this intends to avoid that in the future)

Before:
![testfailold](https://user-images.githubusercontent.com/126646/38021100-3fbaf1c6-327c-11e8-8bae-d3ba46e77408.png)

After:
![testfailnew](https://user-images.githubusercontent.com/126646/38021108-43ac7ef8-327c-11e8-8566-e52bcbaf89b8.png)

If tests pass it still looks the same:

![testok](https://user-images.githubusercontent.com/126646/38021115-4a8e9954-327c-11e8-8fe4-34e889384d3e.png)

Tree-SHA512: 057748c693ca1c80840e4e4cdea8aa1baf8996f03d6805975d8e3c07c4ba0087cd8fa83f891d6bf1af0bfbba88b5d46bd5d852df340d755202bd32ae6f1034b5

Backport of Core PR12811
https://github.com/bitcoin/bitcoin/pull/12811/

Test Plan:

Change a test fail to force failure
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Subscribers: markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D3901

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Mar 28 2018, 14:00
nakihitoCommitted on Aug 19 2019, 18:17
nakihitoPushed on Aug 19 2019, 18:17
Reviewer
Restricted Owners Package
Differential Revision
D3901: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table
Parents
rABCfa8d487a9fbd: Merge #12787: rpc: Adjust ifdef to avoid unreachable code
Branches
Unknown
Tags
Unknown

Changes (1)

PathSize
test/
functional/

rABCd5489985e53c

View Options

test/functional/test_runner.py

Loading...