Page MenuHomePhabricator
Differential D3901

Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table
ClosedPublic
Actions

Authored by nakihito on Aug 17 2019, 00:43.

Details

Reviewers
deadalnix
Fabien
jasonbcox
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd5489985e53c: Merge #12811: test: Make summary row bold-red if any test failed and show…
rABCd5489985e53c: Merge #12811: test: Make summary row bold-red if any test failed and show…
Summary

ffb033a test: List any failed tests at the end of test_runner output (Anthony Towns)
f92541f test: Make summary row bold-red if any test failed (Wladimir J. van der Laan)

Pull request description:

Make the summary row of the test runner bold red if *any* test fails. This helps visibility if something fails.
(yesteryday I had a snafu where I missed that `feature_blocksdir.py` had failed because it's one of the earlier tests in the list, this intends to avoid that in the future)

Before:
![testfailold](https://user-images.githubusercontent.com/126646/38021100-3fbaf1c6-327c-11e8-8bae-d3ba46e77408.png)

After:
![testfailnew](https://user-images.githubusercontent.com/126646/38021108-43ac7ef8-327c-11e8-8566-e52bcbaf89b8.png)

If tests pass it still looks the same:

![testok](https://user-images.githubusercontent.com/126646/38021115-4a8e9954-327c-11e8-8fe4-34e889384d3e.png)

Tree-SHA512: 057748c693ca1c80840e4e4cdea8aa1baf8996f03d6805975d8e3c07c4ba0087cd8fa83f891d6bf1af0bfbba88b5d46bd5d852df340d755202bd32ae6f1034b5

Backport of Core PR12811
https://github.com/bitcoin/bitcoin/pull/12811/

Test Plan
Change a test fail to force failure
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 17 2019, 00:43
Owners added a reviewer: Restricted Owners Package.Aug 17 2019, 00:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2019, 00:43
teamcity added a comment.Aug 17 2019, 00:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 17 2019, 00:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 17 2019, 00:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 17 2019, 00:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 17 2019, 00:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7182: Diff 10851.Aug 17 2019, 00:53
markblundeberg added a subscriber: markblundeberg.Aug 17 2019, 06:30

oh goody, I was looking forward to this one :)

markblundeberg accepted this revision.Aug 17 2019, 09:54
This revision is now accepted and ready to land.Aug 17 2019, 09:54
Closed by commit rABCd5489985e53c: Merge #12811: test: Make summary row bold-red if any test failed and show… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 19 2019, 18:17
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCd5489985e53c: Merge #12811: test: Make summary row bold-red if any test failed and show….
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGd5489985e53c: Merge #12811: test: Make summary row bold-red if any test failed and show….Sep 19 2019, 01:54

Revision Contents
Changeset List

PathSize
test/
functional/
14 lines

Diff 10864

View Options

test/functional/test_runner.py

Loading...