HomePhabricator

Fire TransactionRemovedFromMempool from mempool

Description

Fire TransactionRemovedFromMempool from mempool

Summary:
This commit fires TransactionRemovedFromMempool callbacks from the
mempool and cleans up a bunch of code.

This is a backport of Core PR14384

policyestimator_tests was modified to use TestingSetup because it uses the CTxMemPool::TrimToSize function which now may trigger the signal, but the signals handlers are not setup properly to do so using BasicTestingSetup.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6451

Details

Provenance
251 <13120787+l2a5b1@users.noreply.github.com>Authored on Jul 23 2019, 21:47
deadalnixCommitted on Jun 8 2020, 15:15
deadalnixPushed on Jun 8 2020, 15:15
Reviewer
Restricted Project
Differential Revision
D6451: Fire TransactionRemovedFromMempool from mempool
Parents
rABC095c7367b3d6: scripted-diff: Replace ::mempool with m_node.mempool in tests
Branches
Unknown
Tags
Unknown